[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

Wed Aug 12 12:54:23 PDT 2020

phosek added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:275
+  if (DriverArgs.getLastArgValue(options::OPT_fcxx_abi_EQ) == "Fuchsia")
+    CC1Args.push_back("-fexperimental-relative-c++-abi-vtables");
 }
----------------
mcgrathr wrote:
> It's surprising to me that this is the way to do this.  Isn't there code in the actual front end that tests the TargetCXXABI value?  That seems like the place where it makes sense to have Fuchsia imply specific settings, rather than in the driver.
> 
Couldn't we make this the default in `FuchsiaCXXABI` (akin to `HasThisReturn`)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85802/new/

https://reviews.llvm.org/D85802