[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 12 11:21:52 PDT 2020


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115
+// either due to crashes or false positives.
+const char *getClangTidyBlacklist() {
+  static const std::string FalsePositives =
----------------
aaron.ballman wrote:
> njames93 wrote:
> > Return by StringRef?
> How about `getDisabledClangTidyChecks()` (or literally any other name than blacklist)?
thanks for bringing this to my attention, i will try to be more conscious next time.

I would prefer allow/deny as `disabled` might also be offensive in some contexts. Do you know if we already have some settlements around this one in the wider community?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83224/new/

https://reviews.llvm.org/D83224



More information about the cfe-commits mailing list