[PATCH] D85093: [analyzer] StdLibraryFunctionsChecker: Add support for new functions

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 12 06:17:11 PDT 2020


martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks for your work!



================
Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints.c:190
 void test_notnull_symbolic2(FILE *fp, int *buf) {
-  if (!buf) // bugpath-note{{Assuming 'buf' is null}} \
+  if (!buf)                          // bugpath-note{{Assuming 'buf' is null}} \
             // bugpath-note{{Taking true branch}}
----------------
This formatting change seems unrelated, that would not be a problem in itself, but it degrades the readability a bit (for me).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85093/new/

https://reviews.llvm.org/D85093



More information about the cfe-commits mailing list