[PATCH] D85819: [SyntaxTree] Split tests

Wed Aug 12 02:14:33 PDT 2020

eduucaldas added a comment.

Before we had an UnqualifiedId test that tested for everything in the grammar <https://eel.is/c++draft/expr.prim.id.unqual>. Now we just split this test and test the alternatives separately.

================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:635

-TEST_P(SyntaxTreeTest, UnqualifiedId) {
+TEST_P(SyntaxTreeTest, UnqualifiedIdIdentifier) {
+  EXPECT_TRUE(treeDumpEqual(
----------------
It seems inappropriate to always repeat `UnqualfiiedId`, do you have any other suggestion?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85819/new/

https://reviews.llvm.org/D85819