[PATCH] D85031: [builtins] Unify the softfloat division implementation

Anatoly Trosinenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 12 02:12:57 PDT 2020


atrosinenko added a comment.

On linter diagnostics: error messages are due to linter trying to lint `*.inc` file that is not self-contained by design. D85731: [builtins] Make softfloat-related errors less noisy <https://reviews.llvm.org/D85731> tries to make those errors more meaningful, at least.

Some of `readability-identifier-naming` warnings are just due to code style of runtime library written in C being different from the most of LLVM C++ code base, while some //may// signify actual issues with my variables' names (but here the preference was to carry as much hints as possible in names).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85031/new/

https://reviews.llvm.org/D85031



More information about the cfe-commits mailing list