[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

Aleksandr Platonov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 11 09:49:00 PDT 2020


ArcsinX added inline comments.


================
Comment at: clang/lib/Sema/SemaInit.cpp:3088
   // No structured initializer list to update
   if (!StructuredList)
     return;
----------------
aaron.ballman wrote:
> I would move the check up to here as the only time we should get a null expression is if something else has gone wrong (and update the comment as well).
Could we add `expr` check after `return`? As far as we need to increment `StructuredIndex` in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85193/new/

https://reviews.llvm.org/D85193



More information about the cfe-commits mailing list