[PATCH] D85711: [clangd] Enforce trailing slash for remote index's project root
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 11 01:39:00 PDT 2020
hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:387
+ !llvm::StringRef(ProjectRoot).endswith(llvm::sys::path::get_separator()))
+ ProjectRoot += llvm::sys::path::get_separator();
+
----------------
Instead of handling this in all callers, I think it might be better to move it to `Marshaller` and drop the ends-with-slash assertion there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85711/new/
https://reviews.llvm.org/D85711
More information about the cfe-commits
mailing list