[PATCH] D85619: [clang][OpenMP][OMPBuilder] Use OMPBuilder to CG `omp single`

Fady Ghanim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 10 17:27:35 PDT 2020


fghanim added a comment.

In D85619#2208425 <https://reviews.llvm.org/D85619#2208425>, @kiranchandramohan wrote:

> Before I start, Why is this change all new code and no modification or deletion of existing Clang functionality for omp single/copyprivate?

Because the OMPBuilder currently is not the default way to CG OMP code in clang, which means the old way needs to keep working. So, we cannot delete or modify anything, we can only add the OMPBuilder specific code, and condition its usage on whether `-fopenmp-enable-irbuilder` flag has been issued, or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85619/new/

https://reviews.llvm.org/D85619



More information about the cfe-commits mailing list