[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

Mon Aug 10 14:47:35 PDT 2020

nickdesaulniers marked 2 inline comments as done.
nickdesaulniers added inline comments.

================
Comment at: clang/test/Driver/debug-options.c:371-373
+// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \
+// RUN:        | FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %s
+// NO_DEBUG_UNUSED_TYPES: "-debug-info-kind={{limited|line-tables-only|standalone}}"
----------------
dblaikie wrote:
> nickdesaulniers wrote:
> > dblaikie wrote:
> > > Why does this test -g1 in particular? (that, I think, would always be line-tables-only, on all Clang platforms?) Rather than -g like the positive test?
> > From the previous diff (https://lists.llvm.org/pipermail/llvm-dev/2020-August/144082.html) we added a test to `clang/test/CodeGen/` tests for `-fno...` and `-g1` together. Since I moved those to `%clang_cc1`, I moved the `-fno...` + `-g1` tests here.
> Ah, right right (link might be incorrect though - so including the one where it was discussed: https://reviews.llvm.org/D80242#inline-774452 ) - thanks!
LOL, yeah sorry, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80242/new/

https://reviews.llvm.org/D80242