[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

[Aleksandr Platonov via Phabricator via cfe-commits]

ArcsinX added a comment.

In D85193#2204685 <https://reviews.llvm.org/D85193#2204685>, @aaron.ballman wrote:

> Should the `StructuredIndex` still be incremented even in the case of an error, as done around line 1589 and 1647?

Yes, it looks like we need to increment `StructuredIndex`.

> Do we need a similar change around line 2405?

Think so. But I could not find a test case for this.

> I sort of wonder if the correct change is to make `UpdateStructuredListElement()` resilient to being passed a null `Expr *` and then removing the manual increments when the expression is an error.

Should it be in this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85193/new/

https://reviews.llvm.org/D85193