[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 10 07:24:42 PDT 2020


Eugene.Zelenko added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:70
   motivating use case for these types is to limit 'bit' usage, these types don't
-  automatically promote to 'int' when operations are done between two ``ExtInt(N)``
-  types, instead math occurs at the size of the largest ``ExtInt(N)`` type.
+  automatically promote to 'int' when operations are done between two
+  ``ExtInt(N)`` types, instead math occurs at the size of the largest
----------------
I think //int// should be highlighted too with double back-ticks.


================
Comment at: clang/docs/ReleaseNotes.rst:114
+  this occurs when the use of the ``extern`` keyword is neglected in the
+  declaration
   of a variable in a header file. In some cases, no specific translation unit
----------------
MyDeveloperDay wrote:
> Eugene.Zelenko wrote:
> > This and next line should be merged.
> I knew you'd be perfect to review this...
I'm happy to help!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80031/new/

https://reviews.llvm.org/D80031



More information about the cfe-commits mailing list