[PATCH] D85532: Correctly set CompilingPCH in PrecompilePreambleAction.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 10 06:09:59 PDT 2020
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
================
Comment at: clang/unittests/Frontend/ASTUnitTest.cpp:144
+ CInvok, PCHContainerOps, Diags, FileMgr, false, CaptureDiagsKind::None, 1,
+ TU_Complete, false, false, false);
+ auto File = AU->getFileManager().getFileRef("Textual.h", false, false);
----------------
nit: `ASSRET_TRUE(AU);`
================
Comment at: clang/unittests/Frontend/ASTUnitTest.cpp:146
+ auto File = AU->getFileManager().getFileRef("Textual.h", false, false);
+ assert(File);
+ // Verify that we do not crash here.
----------------
ASSERT_TRUE again
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85532/new/
https://reviews.llvm.org/D85532
More information about the cfe-commits
mailing list