[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

Sat Aug 8 10:30:40 PDT 2020

vrnithinkumar added inline comments.

================
Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:79
+
+// TODO: Enabale this test when "std::swap" is modeled seperately.
+void derefOnStdSwappedNullPtr() {
----------------
vrnithinkumar wrote:
> NoQ wrote:
> > Instead of commenting out tests, i recommend testing the incorrect behavior (with a FIXME comment telling us why it's incorrect). This way we'll be notified when the test is fixed, accidentally or intentionally, and also generally that's more testing for everybody.
> I have commented out this since right now `std::swap` is using `unique_ptr.swap`.
> So note tag for std::swap is added in header file  `system-header-simulator-cxx.h`
> eg:
> `system-header-simulator-cxx.h Line 978: Swapped null smart pointer 'PNull' with smart pointer 'P'`
- Is it okay to add a expected-note on `system-header-simulator-cxx.h`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84600/new/

https://reviews.llvm.org/D84600