[PATCH] D85502: [clangd] Add more error details on the remote index server side

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:322
+    return makeStringError(
+        llvm::formatv("Can not use URI schemes other than file, given: {0}.",
+                      URI)
----------------
i would put this in quotes to make empty strings more easy to detect, i.e. '{0}', same for others.

also s/given/received/ ?


================
Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:328
+    return makeStringError(
+        llvm::formatv("File path {0} doesn't start with RemoteIndexRoot.",
+                      Result.str())
----------------
why not print the real `RemoteIndexRoot` here ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85502/new/

https://reviews.llvm.org/D85502