[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization
Dávid Bolvanský via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 7 14:15:18 PDT 2020
xbolva00 added inline comments.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:6921
+ if (!hasMacro)
+ Diag(SL->getBeginLoc(), diag::warn_concatenated_literal_array_init);
+ }
----------------
riccibruno wrote:
> Should this point to the location of the suspected missing comma?
Yeah, +1. And we should emit fixit too.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85545/new/
https://reviews.llvm.org/D85545
More information about the cfe-commits
mailing list