[PATCH] D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step

[Hubert Tong via Phabricator via cfe-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM with minor edits.



================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:213
+
+  llvm_unreachable("unexpected c++ library type, only libc++ is supported.");
+}
----------------
Minor nit: Follow normal capitalization rules when not formatting for a user-facing error message that falls under https://llvm.org/docs/CodingStandards.html#id15.


================
Comment at: clang/test/Driver/aix-ld.c:336-338
+// RUN:          -target powerpc-ibm-aix7.1.0.0 \
+// RUN:          -stdlib=libstdc++ \
+// RUN:          --sysroot %S/Inputs/aix_ppc_tree \
----------------
Minor nit: We align the options to a utility on later lines with the options to the utility on earlier lines.


================
Comment at: clang/test/Driver/aix-ld.c:343-345
+// RUN:          -target powerpc64-ibm-aix7.1.0.0 \
+// RUN:          -stdlib=libstdc++ \
+// RUN:          --sysroot %S/Inputs/aix_ppc_tree \
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85315/new/

https://reviews.llvm.org/D85315