[clang] 6dc863c - [clang, test, Darwin] Fix tests expecting Darwin target

Thomas Preud'homme via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 7 01:21:30 PDT 2020


Author: Thomas Preud'homme
Date: 2020-08-07T09:21:31+01:00
New Revision: 6dc863cd858f32ef0060c46edda2ab56a3cf76b4

URL: https://github.com/llvm/llvm-project/commit/6dc863cd858f32ef0060c46edda2ab56a3cf76b4
DIFF: https://github.com/llvm/llvm-project/commit/6dc863cd858f32ef0060c46edda2ab56a3cf76b4.diff

LOG: [clang, test, Darwin] Fix tests expecting Darwin target

Clang tests Driver/apple-arm64-arch.c and
Driver/darwin-warning-options.c test Darwin driver functionality but
only require the host system to be Darwin. This leads the tests to fail
when building a cross-compiler on Darwin and to be marked unsupported
when cross-compiling to Darwin from another system. This commit changes
the requirements for those tests to require the target to be Darwin.

Reviewed By: steven_wu

Differential Revision: https://reviews.llvm.org/D85367

Added: 
    

Modified: 
    clang/test/Driver/apple-arm64-arch.c
    clang/test/Driver/darwin-warning-options.c

Removed: 
    


################################################################################
diff  --git a/clang/test/Driver/apple-arm64-arch.c b/clang/test/Driver/apple-arm64-arch.c
index a37346b1a9bb..2c771ee40368 100644
--- a/clang/test/Driver/apple-arm64-arch.c
+++ b/clang/test/Driver/apple-arm64-arch.c
@@ -1,7 +1,7 @@
 // RUN: env SDKROOT="/" %clang -arch arm64 -c -### %s 2>&1 | \
 // RUN:   FileCheck %s
 //
-// REQUIRES: system-darwin
+// REQUIRES: darwin
 // XFAIL: apple-silicon-mac
 //
 // CHECK: "-triple" "arm64-apple-ios{{[0-9.]+}}"

diff  --git a/clang/test/Driver/darwin-warning-options.c b/clang/test/Driver/darwin-warning-options.c
index b0a591eac820..a3301b3fae9a 100644
--- a/clang/test/Driver/darwin-warning-options.c
+++ b/clang/test/Driver/darwin-warning-options.c
@@ -1,4 +1,4 @@
-// REQUIRES: system-darwin
+// REQUIRES: darwin
 
 // Always error about undefined 'TARGET_OS_*' macros on Darwin.
 // RUN: %clang -### %s 2>&1 | FileCheck %s


        


More information about the cfe-commits mailing list