[PATCH] D85503: [clangd] Have template template arguments target their referenced template decl
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 7 00:45:34 PDT 2020
hokein added a comment.
The code looks good.
I think we'd better to have some sort of tests in clang (rather than relying on clangd test). It seems that the only way to test it in clang is through ASTMatcher. Do you mind adding a `templateArgumentLoc` matcher as well? and add a test in `unittests/ASTMatchers/ASTMatchersTraversalTest.cpp`.
With that, I think it would be nice to have two patches, one for clang, the other is for clangd.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85503/new/
https://reviews.llvm.org/D85503
More information about the cfe-commits
mailing list