[PATCH] D85295: [SyntaxTree] Implement the List construct.

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 6 10:44:51 PDT 2020


eduucaldas added inline comments.


================
Comment at: clang/include/clang/Tooling/Syntax/Tree.h:247
+
+  TerminationKind getTerminationKind();
+
----------------
gribozavr2 wrote:
> I just realized that the rest of the syntax tree API does not use the `get~` prefix. However, most of Clang does, as far as I know. Which way should we repaint?
Let's go with Clang! I can make this change in another patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85295/new/

https://reviews.llvm.org/D85295



More information about the cfe-commits mailing list