[PATCH] D85417: [clangd] Fix crash in bugprone-bad-signal-to-kill-thread clang-tidy check.

Aleksandr Platonov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 6 07:23:08 PDT 2020


ArcsinX added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:441
 
+TEST(DiagnosticTest, ClangTidyBadSignalToKillThread) {
+  Annotations Main(R"cpp(
----------------
hokein wrote:
> ClangTidyBadSignalToKillThread doesn't seen ti provide much information about what is testcase testing. Maybe `NoLiteralDataInMacroToken`?
Thanks, renamed. But I want to keep ClangTidy prefix because the problem related with clang-tidy limitations inside clangd.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85417/new/

https://reviews.llvm.org/D85417



More information about the cfe-commits mailing list