[PATCH] D85337: [AMDGPU] gfx1031 target
James Henderson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 6 01:09:45 PDT 2020
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1844
LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1030),
+ LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1031),
LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_XNACK),
----------------
Where's the dedicated llvm-readobj test for this? Please add one. If there exists one for the other AMDGPU flags, extend that one, otherwise, it might be best to write one for the whole set at once.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85337/new/
https://reviews.llvm.org/D85337
More information about the cfe-commits
mailing list