[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 5 17:55:08 PDT 2020


NoQ added inline comments.


================
Comment at: clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp:25
+    PathDiagnosticConsumerOptions DiagOpts, PathDiagnosticConsumers &C,
+    const std::string &prefix, const Preprocessor &PP,
+    const cross_tu::CrossTranslationUnitContext &CTU) {
----------------
vsavchenko wrote:
> As long as it is a new function, I guess we should definitely keep names according to the **Coding Standards**
It's not new but sure!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67422/new/

https://reviews.llvm.org/D67422



More information about the cfe-commits mailing list