[PATCH] D85347: [WebAssembly] Fix types in wasm_simd128.h and add tests

Wed Aug 5 13:37:08 PDT 2020

tlively added inline comments.

================
Comment at: clang/test/Headers/wasm.cpp:1
+// RUN: %clang_cc1 -triple wasm32-unknown-unknown -target-feature +simd128 -fsyntax-only -ffreestanding %s -verify
+// expected-no-diagnostics
----------------
sunfish wrote:
> This test currently passes on trunk without the bug fix here. Could you add a -flax-vector-conversions=none line, similar to the C test, which is the case that the patch here fixes?
I think it's ok that this doesn't test with `-flax-vector-conversions=none`, since that's already tested in the .c file. This pattern of testing is copied from x86intrin.{c,cpp} and that's how this works in those files as well. This .cpp file only exists to additionally test the header contents with `extern "C++"` around them AFAICT.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85347/new/

https://reviews.llvm.org/D85347