[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

Michael Kruse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 5 12:43:52 PDT 2020


Meinersbur added a comment.

I think the ActOnOpenMPDeclareMapperDirective changes should be separated into its own patch. Otherwise, LGTM.



================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:3329
   }
-  OMPDeclareMapperDecl *NewDMD = SemaRef.ActOnOpenMPDeclareMapperDirectiveStart(
-      /*S=*/nullptr, Owner, D->getDeclName(), SubstMapperTy, D->getLocation(),
----------------
The refactoring of ActOnOpenMPDeclareMapperDirective seems unrelated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83261/new/

https://reviews.llvm.org/D83261



More information about the cfe-commits mailing list