[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringLength.h:42
+LLVM_NODISCARD Optional<SVal>
+getCStringLength(CheckerContext &Ctx, const ProgramStateRef &State, SVal Buf);
+
----------------
Just pass by value then. It's already a "Ref".


================
Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringLength.h:50
+
+LLVM_DUMP_METHOD void dumpCStringLengths(const ProgramStateRef State,
                                          raw_ostream &Out = llvm::errs(),
----------------
This `const` does nothing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84979/new/

https://reviews.llvm.org/D84979