[PATCH] D85324: [z/OS] Add z/OS Target and define macros

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 5 09:55:11 PDT 2020


MaskRay added inline comments.


================
Comment at: clang/lib/Basic/Targets/OSTargets.h:745
+    if (this->PointerWidth == 64) {
+      Builder.defineMacro("__64BIT__");
+    }
----------------
anirudhp wrote:
> abhina.sreeskantharajan wrote:
> > anirudhp wrote:
> > > What about the `__LP64__` and the `_LP64` macros?
> > These two are already added in the common code, so it would be redundant to add them again.
> Alright Thanks! 
Omit braces

https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85324/new/

https://reviews.llvm.org/D85324



More information about the cfe-commits mailing list