[PATCH] D79744: clang: Use byref for aggregate kernel arguments

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1997
   case ABIArgInfo::Ignore:
+  case ABIArgInfo::IndirectAliased:
     return false;
----------------
arsenm wrote:
> rjmccall wrote:
> > arsenm wrote:
> > > rjmccall wrote:
> > > > In principle, this can be `inreg` just as much as Indirect can.
> > > The IR verifier currently will reject byref + inreg
> > Why?  `inreg` is essentially orthogonal.
> Mostly inherited from the other similar attribute handling. It can be lifted if there's a use
Plus the name here is isArgInAlloca; this is not necessarily passed in an alloca


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79744/new/

https://reviews.llvm.org/D79744