[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Tue Aug 4 02:59:11 PDT 2020

Szelethus added a comment.

In D67422#2192407 <https://reviews.llvm.org/D67422#2192407>, @NoQ wrote:

> One bit that's not directly related but i decided to keep it from the original patch was moving the plist-html diagnostic builder function into its own file.

That is a great call indeed.

>> I'm also starting to wonder whether this diagnostics infrastructure should be in its own library, not in libAnalysis -- what do you think?
>
> Maybe! libAnalysis is currently a mess; it's basically a collection of all static-analyzer-ish things that are also used outside of the static analyzer. That's indeed not a good definition for a library. It incorporates a number of completely unrelated things.

Not to mention my new plugins were knocked around all over the place, and eventually they also landed in it. I think libAnalysis is indeed well overdue for a revision, maybe sooner rather then later. There aren't too many other changes in this patch, maybe its worth doing this right away? I don't insist.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67422/new/

https://reviews.llvm.org/D67422