[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions
Vince Bridgers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 3 13:40:37 PDT 2020
vabridgers created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
vabridgers requested review of this revision.
This change squelches the warning for a cast from integer to fixed point
conversions.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D85157
Files:
clang/lib/Sema/SemaCast.cpp
clang/test/Sema/warn-bad-function-cast.c
Index: clang/test/Sema/warn-bad-function-cast.c
===================================================================
--- clang/test/Sema/warn-bad-function-cast.c
+++ clang/test/Sema/warn-bad-function-cast.c
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 %s -fsyntax-only -Wno-unused-value -Wbad-function-cast -triple x86_64-unknown-unknown -verify
+// RUN: %clang_cc1 %s -fsyntax-only -Wno-unused-value -Wbad-function-cast -DFIXED_POINT -ffixed-point -triple x86_64-unknown-unknown -verify
// rdar://9103192
void vf(void);
@@ -43,5 +44,9 @@
(int)bf(); /* expected-warning {{cast from function call of type '_Bool' to non-matching type 'int'}} */
(__SIZE_TYPE__)pf1(); /* expected-warning {{cast from function call of type 'char *' to non-matching type 'unsigned long'}} */
(__PTRDIFF_TYPE__)pf2(); /* expected-warning {{cast from function call of type 'int *' to non-matching type 'long'}} */
+
+#ifdef FIXED_POINT
+ (void)(_Fract) if1(); // no warning
+#endif
}
Index: clang/lib/Sema/SemaCast.cpp
===================================================================
--- clang/lib/Sema/SemaCast.cpp
+++ clang/lib/Sema/SemaCast.cpp
@@ -2657,6 +2657,8 @@
return;
if (SrcType->isComplexIntegerType() && DestType->isComplexIntegerType())
return;
+ if (SrcType->isIntegerType() && DestType->isFixedPointType())
+ return;
Self.Diag(SrcExpr.get()->getExprLoc(),
diag::warn_bad_function_cast)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85157.282716.patch
Type: text/x-patch
Size: 1424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200803/0a6f3235/attachment.bin>
More information about the cfe-commits
mailing list