[PATCH] D82562: Implement AVX ABI Warning/error

dmajor via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 3 12:24:56 PDT 2020


dmajor added a comment.

@erichkeane, could you help me understand what is the action item of these warnings?

In Firefox we don't require AVX so our compilations generally don't enable the feature. (A very small number of files do come with AVX versions, mostly in imported media codecs, but they are reasonably well-isolated from other code.) It's not clear to me what the warning wants me to do. I can't enable AVX across the board, and I can't change all the code that uses large types as parameters. I feel like the only thing to do is silence the warning since there are enough instances that people will complain about log spam. Have I misunderstood the situation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82562/new/

https://reviews.llvm.org/D82562



More information about the cfe-commits mailing list