[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 3 11:34:46 PDT 2020


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:4076-4077
+      R"cpp(
+struct X{
+  struct Y{};
+};
----------------
Please add spaces before `{`.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:4082
+// i.e. create a syntax node for the outer member pointer
+void (X::Y::**xyp)(const int*, char);
+)cpp",
----------------
Could you add separate tests for `X::Y::` and for `**`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85146/new/

https://reviews.llvm.org/D85146



More information about the cfe-commits mailing list