[PATCH] D79744: clang: Use byref for aggregate kernel arguments

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 3 10:31:58 PDT 2020


rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:1997
   case ABIArgInfo::Ignore:
+  case ABIArgInfo::IndirectAliased:
     return false;
----------------
arsenm wrote:
> rjmccall wrote:
> > In principle, this can be `inreg` just as much as Indirect can.
> The IR verifier currently will reject byref + inreg
Why?  `inreg` is essentially orthogonal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79744/new/

https://reviews.llvm.org/D79744



More information about the cfe-commits mailing list