[PATCH] D68997: Allow searching for prebuilt implicit modules.

[Alexandre Rames via Phabricator via cfe-commits]

arames added inline comments.


================
Comment at: clang/include/clang/Lex/HeaderSearch.h:187
+  /// The hash used for module cache paths.
+  std::string ModuleHash;
+
----------------
In the previous version of this patch, this value was derived from the stem of `ModuleCachePath`.
However we do not want to depend on `ModuleCachePath` being set to be able to retrieve the module hash. See the update in the test.


================
Comment at: clang/test/Modules/prebuilt-implicit-modules.m:11
+
+// Check a module cache path is not required when all modules resolve to a
+// prebuilt implicit modules.
----------------
For this to be possible, the computation of the paths to (potential) implicit prebuilt modules cannot depend on the cache path being set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68997/new/

https://reviews.llvm.org/D68997