[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 31 06:25:22 PDT 2020


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:76
+
+  Added an option GetConfigPerFile to support including files which use
+  different naming styles.
----------------
Please enclose GetConfigPerFile in single back-quotes.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst:719
+
+    When ``true`` the check will look for the configuration for where an
+    identifier is declared. Useful for when you include header files that use
----------------
Please use single back-quotes for option values. Same below.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst:720
+    When ``true`` the check will look for the configuration for where an
+    identifier is declared. Useful for when you include header files that use
+    a different style. 
----------------
I think will be good idea to reformulate without //you//, like //header file included//.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84814/new/

https://reviews.llvm.org/D84814



More information about the cfe-commits mailing list