[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 30 16:36:32 PDT 2020
rsmith added a comment.
In D84637#2175681 <https://reviews.llvm.org/D84637#2175681>, @erichkeane wrote:
> Based on richard's suggestions, that seems about right. However I believe all the asserts should have a message to go along with them as we typicaly do.
In this case, the asserts are enforcing AST invariants, so I think they're OK without diagnostics.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84637/new/
https://reviews.llvm.org/D84637
More information about the cfe-commits
mailing list