[PATCH] D84894: [clangd] Implement Relations request for remote index
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 30 03:43:34 PDT 2020
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
================
Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:391
+ auto Deserialized = ProtobufMarshaller.fromProtobuf(*Serialized);
+ ASSERT_TRUE(Deserialized);
+}
----------------
i think you should still check for `Deserialized->first == ID` and `Deserialized->second->ID == Sym.Id`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84894/new/
https://reviews.llvm.org/D84894
More information about the cfe-commits
mailing list