[PATCH] D84912: [clangd] findNearbyIdentifier(): fix the word search in the token stream.

Aleksandr Platonov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 30 02:38:11 PDT 2020


ArcsinX added a comment.

In D84912#2184147 <https://reviews.llvm.org/D84912#2184147>, @kadircet wrote:

> oh and also, how did you notice the discrepancy? was it a random encounter while reading the code or did you notice a misbehaviour?

Case was like this

  void f1(int [[paramValue]]){
  }
  
  void f2(int paramValue){
  }
  
  void f3(int paramValue){
  }
  
  void f4(int paramValue){
  // param^Value
  }

Because of
floor(log2(8)) = floor(log2(8)) ... = floor(log2(15)) = 3


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84912/new/

https://reviews.llvm.org/D84912



More information about the cfe-commits mailing list