[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 30 02:18:33 PDT 2020


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:112
+    if (!IndexRoot.empty()) {
+      llvm::DenseSet<SymbolID> ExcludeIDs;
+      for (const auto &Sym : *Result.Symbols)
----------------
I think we could reuse the `FileShardedIndex` to do the filtering job, rather than implementing a new one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84811/new/

https://reviews.llvm.org/D84811



More information about the cfe-commits mailing list