[PATCH] D84455: [Concepts] Fix a deserialization crash.

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 29 23:44:45 PDT 2020


nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.

In D84455#2170461 <https://reviews.llvm.org/D84455#2170461>, @hokein wrote:

> btw, `getTypeConstraint` and `hasTypeConstraint` APIs are quite easy to be misused (there is another similar bug in getAssociatedConstraints <https://github.com/llvm/llvm-project/blob/master/clang/include/clang/AST/DeclTemplate.h#L1367-L1368>), I think we need to refine them (rename or so) to make them less confusing.

Agreed, this seems a bit error-prone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84455/new/

https://reviews.llvm.org/D84455



More information about the cfe-commits mailing list