[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a small nit about the tests, though I'm still surprised `IdentLoc` is valid even when there's no identifier present. :-)



================
Comment at: clang/test/Sema/void-unnamed.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+
----------------
I think these test should be combined with the other ones (no real need for separate files to test the same functionality, as that causes tests to be a bit slower to run for no real gain).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84678/new/

https://reviews.llvm.org/D84678