[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

Matt Morehouse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 29 09:06:12 PDT 2020


morehouse added inline comments.


================
Comment at: llvm/lib/Passes/PassRegistry.def:92
 MODULE_PASS("verify", VerifierPass())
+MODULE_PASS("dfsan", DataFlowSanitizerPass())
 MODULE_PASS("asan-module", ModuleAddressSanitizerPass(/*CompileKernel=*/false, false, true, false))
----------------
Nit:  maybe "dfsan-module" for consistency?


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:778
+bool DataFlowSanitizer::runImpl(Module &M) {
+  init(M);
+
----------------
Do we need a bool to avoid calling `init` more than once?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84707/new/

https://reviews.llvm.org/D84707



More information about the cfe-commits mailing list