[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 29 04:35:40 PDT 2020


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h:76
+  /// Stores the style options for a given directory.
+  mutable llvm::StringMap<std::vector<llvm::Optional<NamingStyle>>>
+      NamingStylesCache;
----------------
And could you please document what the indices for the vector are?


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-multiple-styles.cpp:7
+
+// C++11 isnt explicitly required, but failing to specify a standard means the
+// check will run multiple times for different standards. This will cause the
----------------
"isn't"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84814/new/

https://reviews.llvm.org/D84814



More information about the cfe-commits mailing list