[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 29 04:23:44 PDT 2020


steakhal added inline comments.


================
Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19
+#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
+#include "llvm/Config/config.h"
+#include "gtest/gtest.h"
----------------
mgorny wrote:
> `config.h` is a private LLVM header and must not be used from clang.
I'm not a CMake profession, but shouldn't it be declared private to the LLVM target in the corresponding CMakeLists file then?

How do you query whether clang has built with Z3 or not @mgorny?
I'm including that header only for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78704/new/

https://reviews.llvm.org/D78704



More information about the cfe-commits mailing list