[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

Tue Jul 28 17:03:42 PDT 2020

MaskRay accepted this revision.
MaskRay added a comment.

LGTM.

================
Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24
+# works as expected
+config.substitutions.append(
+    ('%update_cc_test_checks_llvm_bin', "%s %s %s" % (
----------------
vitalybuka wrote:
> arichardson wrote:
> > MaskRay wrote:
> > > The substitution is here just to make a test. Can it be tested with existing substitutions?
> > I can't think of an easy way since we need to invoke update_cc_test_checks.py without the "--clang" argument and we need a substitution for the path to the update script.
> If there are concerns here, I'd recommend to land minimal fix for the tool and move test plumbing into a separate patch.
> If there are concerns here, I'd recommend to land minimal fix for the tool and move test plumbing into a separate patch.

+1

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84511/new/

https://reviews.llvm.org/D84511