[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)
Tom Stellard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 28 16:48:59 PDT 2020
tstellar marked an inline comment as done.
tstellar added inline comments.
================
Comment at: clang/test/CodeGen/builtins-overflow.c:123
+ // CHECK: br i1 [[C2]]
+ int r;
+ if (__builtin_mul_overflow(x, y, &r))
----------------
vsk wrote:
> vsk wrote:
> > Could you add a test for the volatile result case?
> I think this is still missing?
Yes, I forgot to add this, there is one in the latest patch now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84405/new/
https://reviews.llvm.org/D84405
More information about the cfe-commits
mailing list