[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

Joel E. Denny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 28 13:17:26 PDT 2020


jdenny added inline comments.


================
Comment at: clang/lib/Basic/OpenMPKinds.cpp:73-74
         .Default(OMPC_MOTION_MODIFIER_unknown);
+    if (OpenMPVersion < 51 && Type != OMPC_MOTION_MODIFIER_mapper)
+      return OMPC_MOTION_MODIFIER_unknown;
+    return Type;
----------------
ABataev wrote:
> Better to check for the new clauses here:
> ```
> if (OpenMPVersion >= 51 && Type == OMPC_MOTION_MODIFIER_present)
> ....
> ```
I think I've done what you're after here.  This now looks a look like the related code for map type modifiers above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84711/new/

https://reviews.llvm.org/D84711



More information about the cfe-commits mailing list