[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)
Joel E. Denny via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 28 12:49:50 PDT 2020
jdenny added inline comments.
================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:3462
+ // OpenMP 5.1 accepts an optional ',' even if the next character is ':'.
+ // TODO: Is that intentional?
+ if (Tok.is(tok::comma))
----------------
ABataev wrote:
> `FIXME`. This is a bug.
I think you mean:
* It's a bug in TR8.
* I should change TODO to FIXME.
* This patch implements and tests the TR8 bug, and I should leave it that way for now.
Is all that right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84711/new/
https://reviews.llvm.org/D84711
More information about the cfe-commits
mailing list