[PATCH] D84453: [clang-tidy] Suppress one unittest on macOS.

Tue Jul 28 04:54:23 PDT 2020

njames93 added a comment.

In D84453#2177665 <https://reviews.llvm.org/D84453#2177665>, @NoQ wrote:

> In D84453#2171548 <https://reviews.llvm.org/D84453#2171548>, @njames93 wrote:
>
>> I was having issues with this test case under macos in D82188 <https://reviews.llvm.org/D82188>.
>> It would fail for seemingly no apparent reason until I disable a test in a different translation unit.
>> This made me think there is a subtle bug in the linker used on macos. That could also explain why asan is having a hard time with this as well. 
>> I got as far as seeing that runCheckOnCode was called, the check was instantiated but its matchers never got registered effectively meaning it didn't run.
>
> Damn, i'm very glad you showed up. I can reproduce your problem as well, so ASan is probably not at fault. I'll try to talk to linker folks to see if they can fix this.
>
> I guess i'll still commit this patch so that to unbreak the buildbots but i'll keep an eye on this issue.

If it is an issue with the linking and the issue lies within the system ld binary on mac os then we really can't do much here apart from raise an issue with apple folks.
Be interesting to see if this bug is present when using lld on mac os, however I don't have a mac so its kind of hard for me to test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84453/new/

https://reviews.llvm.org/D84453