[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

Mon Jul 27 22:15:09 PDT 2020

NoQ added a comment.

In D84453#2171548 <https://reviews.llvm.org/D84453#2171548>, @njames93 wrote:

> I was having issues with this test case under macos in D82188 <https://reviews.llvm.org/D82188>.
> It would fail for seemingly no apparent reason until I disable a test in a different translation unit.
> This made me think there is a subtle bug in the linker used on macos. That could also explain why asan is having a hard time with this as well. 
> I got as far as seeing that runCheckOnCode was called, the check was instantiated but its matchers never got registered effectively meaning it didn't run.

Damn, i'm very glad you showed up. I can reproduce your problem as well, so ASan is probably not at fault. I'll try to talk to linker folks to see if they can fix this.

I guess i'll still commit this patch so that to unbreak the buildbots but i'll keep an eye on this issue.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84453/new/

https://reviews.llvm.org/D84453