[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 27 15:18:08 PDT 2020
compnerd added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:173
+ Arg *A = Args.getLastArg(options::OPT_g_Group);
+ if (A && !A->getOption().matches(options::OPT_g0) &&
+ !A->getOption().matches(options::OPT_gstabs))
----------------
Why not hoist the `nullptr` check into the assignment?
```
if (Arg *A = Args.getLastArg(options::OPT_g_Group)
if (!A->getOption().matches(options::OPT_g0) &&
!A->getOption().matches(options::OPT_gstabs))
return true;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84565/new/
https://reviews.llvm.org/D84565
More information about the cfe-commits
mailing list